如何在C#代码中检查死锁的可能性 [英] How to check possibility of deadlock in c# code
问题描述
我的应用程序有时(但不总是)停止在下面的代码中,有时却停止。
My application sometimes stop in the below code, not always but sometimes.
所有3种方法 CalcQuarterlyFigures
, CalcWeeklyFigures
& CalcMonthlyFigures
返回 Task< List< MyClass>>
。
All the 3 methods CalcQuarterlyFigures
, CalcWeeklyFigures
& CalcMonthlyFigures
return Task<List<MyClass>>
.
注意,它在 foreach
循环内运行。
Note, this runs inside a foreach
loop.
List<Task> TaskList = new List<Task>();
if(i.DoCalculateAllHistory) {
var quarterly = CalcQuarterlyFigures(QuarterlyPrices, i.SeriesID);
TaskList.Add(quarterly);
var weekly = CalcWeeklyFigures(WeeklyPrices, i.SeriesID);
TaskList.Add(weekly);
var monthly = CalcMonthlyFigures(MonthlyPrice, i.SeriesID);
TaskList.Add(monthly);
Task.WaitAll(TaskList.ToArray());
if(monthly.Result.Count > 0)
monthlyPerfFig.AddRange(monthly.Result);
if(weekly.Result.Count > 0)
weeklyPerfFig.AddRange(weekly.Result);
if(quarterly.Result.Count > 0)
quartPerfFig.AddRange(quarterly.Result);
} else {
monthlyPerfFig.AddRange(await CalcMonthlyFigures(MonthlyPrice, i.SeriesID));
}
我在这里错过了任何导致死锁的东西吗?
Am I missing anything here that leads to dead lock ?
推荐答案
在提供的上下文中(.NET 4.6.1的示例代码) Task.WaitAll(TaskList。 ToArray())
会导致死锁。
绝对有用的来源:不要阻止异步代码
In provided context (sample code of .NET 4.6.1) Task.WaitAll(TaskList.ToArray())
will cause a deadlock.
Definitely useful source: Don't Block on Async Code
您应该使代码块完全异步
You should make you code block fully asynchronous
if (i.DoCalculateAllHistory)
{
var quarterlyTask = CalcQuarterlyFigures(QuarterlyPrices, i.SeriesID);
var weeklyTask = CalcWeeklyFigures(WeeklyPrices, i.SeriesID);
var monthlyTask = CalcMonthlyFigures(MonthlyPrice, i.SeriesID);
// Task.WhenAll accepts "params" array
await Task.WhenAll(quarterlyTask, weeklyTask, monthlyTask);
// You don't need to check for .Count
// nothing will be added when empty list given to .AddRange
quartPerfFig.AddRange(await quarterlyTask);
weeklyPerfFig.AddRange(await weeklyTask);
monthlyPerfFig.AddRange(await monthlyTask);
}
else
{
var monthly = await CalcMonthlyFigures(MonthlyPrice, i.SeriesID);
monthlyPerfFig.AddRange(monthly);
}
这篇关于如何在C#代码中检查死锁的可能性的文章就介绍到这了,希望我们推荐的答案对大家有所帮助,也希望大家多多支持IT屋!