php - 快速重构 [英] php - quick refactoring

问题描述

我有两种方法，它们几乎完全相同，我希望有人帮助我重构它们:

I have 2 methods, that are pretty much exactly the same and I'd likie someone to help me refactor them:

public static function searchFromVideoRequest($word, $returnPropelObjects = false)
{
    $c = new Criteria();
    $c->addJoin(YoutubeVideoPeer::ID,ItemPeer::YOUTUBE_VIDEO_ID);
    $c->addSelectColumn(self::TITLE);
    $c->addSelectColumn(self::ID);
    $c->add(ItemPeer::TITLE, '%'.$word.'%', Criteria::LIKE);
    $c->addAnd(self::YOUTUBE_VIDEO_ID, null, Criteria::ISNOTNULL);
$c->addAscendingOrderByColumn(self::TITLE);
   if ($returnPropelObjects)
          return self::doSelect($c);

        $stmt = self::doSelectStmt($c);
        $results = array();
        while ($row = $stmt->fetch(PDO::FETCH_ASSOC)) {
          $results[] = $row;
        }
        return $results;
}

public static function searchFromFlickrRequest($word, $returnPropelObjects = false)
{
    $c = new Criteria();
    $c->addJoin(FlickrPhotoPeer::ID,ItemPeer::FLICKR_PHOTO_ID);
    $c->addSelectColumn(self::TITLE);
    $c->addSelectColumn(self::ID);
    $c->add(ItemPeer::TITLE, '%'.$word.'%', Criteria::LIKE);
    $c->addAnd(self::FLICKR_PHOTO_ID, null, Criteria::ISNOTNULL);
    $c->addAscendingOrderByColumn(self::TITLE);
   if ($returnPropelObjects)
          return self::doSelect($c);

        $stmt = self::doSelectStmt($c);
        $results = array();
        while ($row = $stmt->fetch(PDO::FETCH_ASSOC)) {
          $results[] = $row;
        }
        return $results;
}

谢谢

推荐答案

要重构此类方法，您可以将它们拆分为几个方法，这些方法将包含公共代码并使它们成为私有的，这样任何人都不能在类之外使用它们:

To refactor such methods you can split up them into a few methods that will contain common code and make them private, so no one can use them outside the class:

public static function searchFromVideoRequest($word, $returnPropelObjects = false)
{
    $c = self::buildSearchCriteria($word);
    $c->addJoin(YoutubeVideoPeer::ID,ItemPeer::YOUTUBE_VIDEO_ID);
    $c->addAnd(self::YOUTUBE_VIDEO_ID, null, Criteria::ISNOTNULL);
    return self::getSearchResult($c, $returnPropelObjects);
}

public static function searchFromFlickrRequest($word, $returnPropelObjects = false)
{
    $c = self::buildSearchCriteria($word);
    $c->addJoin(FlickrPhotoPeer::ID,ItemPeer::FLICKR_PHOTO_ID);
    $c->addAnd(self::FLICKR_PHOTO_ID, null, Criteria::ISNOTNULL);
    return self::getSearchResult($c, $returnPropelObjects);
}

private static function buildSearchCriteria($word)
{
    $c = new Criteria();
    $c->addSelectColumn(self::TITLE);
    $c->addSelectColumn(self::ID);
    $c->add(ItemPeer::TITLE, '%'.$word.'%', Criteria::LIKE);
    $c->addAscendingOrderByColumn(self::TITLE);
    return $c;
}

private static function getSearchResult($c, $returnPropelObjects)
{
    if ($returnPropelObjects)
      return self::doSelect($c);

    $stmt = self::doSelectStmt($c);
    $results = array();
    while ($row = $stmt->fetch(PDO::FETCH_ASSOC)) {
      $results[] = $row;
    }
    return $results;
}

PS:我认为这个问题没问题.

PS: And I think the question is OK.

这篇关于php - 快速重构的文章就介绍到这了，希望我们推荐的答案对大家有所帮助，也希望大家多多支持IT屋！