SONAR 问题 - 关闭此 FileInputStream [英] SONAR issue - Close this FileInputStream

问题描述

如何解决此 SONAR 问题?关闭这个 FileInputStream.

How do I fix this SONAR issue? Close this FileInputStream.

提前致谢！

File billFile = new File(filePath);
try (BufferedReader br = new BufferedReader(new InputStreamReader(
        new FileInputStream(billFile), DEFAULTCHARSET));) { 

    ... 
    br.close();
} catch (FileNotFoundException e) {
    LOG.error(e.getMessage());              
} catch (IOException e) {
    LOG.error(e.getMessage(), e);               
}

推荐答案

当你使用 try-with-resources 语句，您不再需要显式关闭 BufferedReader ，因此只需删除 br.close(); 来自您当前的代码，这应该足以解决您的声纳问题，因为 BufferedReader 将在关闭时关闭底层 InputStreamReader 并且 InputStreamReader 将在关闭时关闭您的 FileInputStream.

As you use the try-with-resources statement, you don't need to close your BufferedReader explicitly anymore so simply remove br.close(); from your current code which should be enough to fix your sonar issue as a BufferedReader will close the underlying InputStreamReader on close and the InputStreamReader will close your FileInputStream on close.

如果还不够，您可以简单地重写您的代码，将您的 FileInputStream 显式声明为您的 try-with-resources 语句的资源，如下所示:

If not enough, you could simply rewrite your code to explicitly declare your FileInputStream as a resource of your try-with-resources statement like below:

try (FileInputStream fis = new FileInputStream(billFile);
     Reader reader = new InputStreamReader(fis, DEFAULTCHARSET);
     BufferedReader br = new BufferedReader(reader) {
     ...

<小时>

如果仍然无法正常工作，请确保为 Java 7 及更高版本正确配置了声纳，否则它不会意识到可能导致此违规的 try-with-resources 语句提高.

这篇关于SONAR 问题 - 关闭此 FileInputStream的文章就介绍到这了，希望我们推荐的答案对大家有所帮助，也希望大家多多支持IT屋！