为什么我无法将数据发送到SQL Server？ [英] Why am I not able to send data to SQL server?

问题描述

我正在尝试创建一个应用程序，当安装在其他系统中时，必须收集详细信息并发送到我的SQL服务器。 
 
在SQL Server中，我将所有列都设为varchar（70）。 
我认为问题出在数据类型上，所以我决定在下面的代码中删除OSInstallDate和
 LastBootUpTime并检查。但还没有插入其他数据。 
 sql连接没有问题，因为我已经检查过了。 
 
如果有任何其他方式收集所有这些数据并发送到我的数据库，我会感兴趣。

我尝试过：

 SelectQuery Sq1 =  new  SelectQuery（  Win32_OperatingSystem）; 
 ManagementObjectSearcher objOSDetails1 =  new  ManagementObjectSearcher（Sq1）; 
  foreach （ManagementObject mo1  in  objOSDetails1.Get（））
 {
 OperatingSystem = mo1 [  caption]。ToString（）; 
 ServicePack = mo1 [  csdversion]。ToString（）; 
 OSVersion = mo1 [  version]。ToString（）; 
 OSArchitecture = mo1 [  OSArchitecture]。ToString（）; 
 OSSno = mo1 [  serialnumber]。ToString（）; 
 OSInstallDate = mo1 [  InstallDate]。ToString（）; 
 OSDescription = mo1 [ 描述]。ToString（）; 
 LastBootUpTime = mo1 [  LastBootUpTime]。ToString（）; 
 SPMajorVersion = mo1 [  ServicePackMajorVersion]。ToString（）; 
 RegUser = mo1 [  RegisteredUser]。ToString（）; 
 OSStatus = mo1 [  status]。ToString（）; 
} 
 cmd1 =  new  SqlCommand（  INSERT INTO [dbo]。[OSInfo]（[LastUpdatedOn]，[IPAddress]，[OperatingSystem]，[ServicePack]，[OSVersion]，[OSArchitecture]，[OSSno]，[OSInstallDate]，[Description]，[ LastBootUpTime]，[SPMajorVersion]，[RegUser]，[OSStatus]）VALUES（getdate（），' + IPA +  '，' + OperatingSystem +  '，' + ServicePack +  '，' + OSVersion +  '，' + OSArchitecture +  ' ，' + OSSno +  '，' + OSInstallDate +  '，' + OSDescription +  '，' + LastBootUpTime +  '，' + SPMajorVersion +  '，' + RegUser +  '，' + OSStatus +  '），con）; 
 
  int  numrows1 = cmd1.ExecuteNonQuery（）; 

解决方案

您正在执行 foreach 循环之外的命令，因此只有最后一条记录将保存在数据库中。如果要保存所有记录，可能需要将命令执行放在循环中。

 cmd1 =  new  SqlCommand（  INSERT INTO [dbo]。[OSInfo]（[LastUpdatedOn]，[IPAddress] ]，[OperatingSystem]，[ServicePack]，[OSVersion]，[OSArchitecture]，[OSSno]，[OSInstallDate]，[Description]，[LastBootUpTime]，[SPMajorVersion]，[RegUser]，[OSStatus]）VALUES（getdate（ ），' + IPA +  '，' + OperatingSystem +  '，' + ServicePack +  '，' + OSVersion +  '，' + OSArchitecture +  '，' + OSSno +  '，' + OSInstallDate +  '，' + OSDescription +  '，' + LastBootUpTime +  '，' + SPMajorVersion +  '，'  + RegUser +  '，' + OSStatus +  '），con）; 

不是你的解决方案问题，但你有另一个问题。

永远不要通过连接字符串来构建SQL查询。迟早，您将使用用户输入来执行此操作，这会打开一个名为SQL注入的漏洞，这对您的数据库很容易并且容易出错。

名称中的单引号你的程序崩溃。如果用户输入像Brian O'Conner这样的名称可能会使您的应用程序崩溃，那么这是一个SQL注入漏洞，崩溃是最少的问题，恶意用户输入，并且它被提升为具有所有凭据的SQL命令。

SQL注入 - 维基百科 [ ^ ]

SQL注入 [ ^ ]

按示例进行SQL注入攻击 [ ^ ]

PHP：SQL注入 - 手册 [ ^ ]

SQL注入预防备忘单 - OWASP [ ^ ]

I am trying make an application which when installed in other system, has to collect details and send to my SQL server.

In SQL Server, I have made all columns as varchar(70).
I thought the problem was with datatypes, so I decided to remove OSInstallDate and  
LastBootUpTime in the below code and check. But still other data are not being inserted.
There is no problem with sql connection as I have checked it already.

If there's any other way of collecting all these data and sending to my database, I would be interested.

What I have tried:

SelectQuery Sq1 = new SelectQuery("Win32_OperatingSystem");
                ManagementObjectSearcher objOSDetails1 = new ManagementObjectSearcher(Sq1);
                foreach (ManagementObject mo1 in objOSDetails1.Get())
                {
                    OperatingSystem = mo1["caption"].ToString();
                    ServicePack = mo1["csdversion"].ToString();
                    OSVersion = mo1["version"].ToString();
                    OSArchitecture = mo1["OSArchitecture"].ToString();
                   OSSno = mo1["serialnumber"].ToString();
                   OSInstallDate = mo1["InstallDate"].ToString();
                    OSDescription = mo1["Description"].ToString();
                    LastBootUpTime = mo1["LastBootUpTime"].ToString();
                    SPMajorVersion = mo1["ServicePackMajorVersion"].ToString();
                    RegUser = mo1["RegisteredUser"].ToString();
                    OSStatus = mo1["status"].ToString();
                }
                cmd1 = new SqlCommand("INSERT INTO [dbo].[OSInfo]([LastUpdatedOn],[IPAddress],[OperatingSystem],[ServicePack],[OSVersion],[OSArchitecture],[OSSno],[OSInstallDate],[Description],[LastBootUpTime],[SPMajorVersion],[RegUser],[OSStatus]) VALUES (getdate(),'" + IPA + "','" + OperatingSystem + "','" + ServicePack + "','" + OSVersion + "','" + OSArchitecture + "','" + OSSno + "','" + OSInstallDate + "','" + OSDescription + "','" + LastBootUpTime + "','" + SPMajorVersion + "','" + RegUser + "','" + OSStatus + "')", con);
                
                int numrows1 = cmd1.ExecuteNonQuery();

解决方案

You are executing the command outside of foreach loop so only the last record will be saved in the database. If you want to save all the records, you might want to put the command execution inside the loop.

cmd1 = new SqlCommand("INSERT INTO [dbo].[OSInfo]([LastUpdatedOn],[IPAddress],[OperatingSystem],[ServicePack],[OSVersion],[OSArchitecture],[OSSno],[OSInstallDate],[Description],[LastBootUpTime],[SPMajorVersion],[RegUser],[OSStatus]) VALUES (getdate(),'" + IPA + "','" + OperatingSystem + "','" + ServicePack + "','" + OSVersion + "','" + OSArchitecture + "','" + OSSno + "','" + OSInstallDate + "','" + OSDescription + "','" + LastBootUpTime + "','" + SPMajorVersion + "','" + RegUser + "','" + OSStatus + "')", con);

Not a solution to your question, but another problem you have.
Never build an SQL query by concatenating strings. Sooner or later, you will do it with user inputs, and this opens door to a vulnerability named "SQL injection", it is dangerous for your database and error prone.
A single quote in a name and your program crash. If a user input a name like "Brian O'Conner" can crash your app, it is an SQL injection vulnerability, and the crash is the least of the problems, a malicious user input and it is promoted to SQL commands with all credentials.
SQL injection - Wikipedia[^]
SQL Injection[^]
SQL Injection Attacks by Example[^]
PHP: SQL Injection - Manual[^]
SQL Injection Prevention Cheat Sheet - OWASP[^]

这篇关于为什么我无法将数据发送到SQL Server？的文章就介绍到这了，希望我们推荐的答案对大家有所帮助，也希望大家多多支持IT屋！