C＃初学者问题 [英] C# Beginner problem

问题描述

问题是如果我输入0，那么我会退出它们，但是当我退出它们时，我发现该值已输入无效。我不想那样。我做错了什么，我该怎么办？ />

The problem is if I enter 0,The instuctions appear but when I exit them,I find out that the value has entered Invalid also.I do not want that.What am I doing wrong and what should I do?

Console.WriteLine("Choose what type of attack");
           decisiontr = Console.ReadLine();
           if (decisiontr == "1" || decisiontr == "2" || decisiontr == "3" || decisiontr == "4" || decisiontr == "5" || decisiontr == "6" ||
               decisiontr == "7" || decisiontr == "8" || decisiontr == "9")
           {
               decision = int.Parse(decisiontr);
           }
           else if (decisiontr == "0")
           { instructions(); }
           if (decisiontr != "1" && decisiontr != "2" && decisiontr != "3" && decisiontr != "4" &&
                   decisiontr != "5" && decisiontr != "6" && decisiontr != "7" && decisiontr != "8" && decisiontr != "9" && decisiontr!="0")
           { HeroATTAX.Invalid(); }
           Console.Clear();
           HeroATTAX attack = new HeroATTAX();

推荐答案

你做错了什么？您以一种可怕的，不准确的方式编写代码，硬编码立即常量并且不使用调试器来解决您的简单问题。你也给变量命名不好。



例如，你的第一个条件可能看起来更好：

What you are doing wrong? You write code in a monstrous, inaccurate way, hard-code immediate constants and don't use the debugger to solve your simple problem. You also give bad names to variables.

For example, your first condition could look better:

const byte decisionMin = 1;
const byte decisionMax = 9;

//...

string decisionInput = Console.ReadLine();
byte decision;
if (!byte.TryParse(out decision))
   return; // or do something else, say, ask to repeat input
if (decisionMin <= decision && decision <= decisionMax)
   //...

依此类推......



准确写完所有内容; 2）使用你的大脑; 3）了解你在每一行中所做的事情;你会得到你的结果。即使是对运行时最轻微的担忧，也要始终使用调试器。

-SA

这篇关于C＃初学者问题的文章就介绍到这了，希望我们推荐的答案对大家有所帮助，也希望大家多多支持IT屋！