C语言中的冒泡排序通用实现 [英] Bubble sort universal implementation in C
问题描述
我正在尝试创建通用的冒泡排序功能.它允许用户编写自己的比较和交换功能.我为int类型实现了交换和比较功能,但是当我为下一个数组运行代码时:{3,5,8,9,1,2,4,7,6,0},我得到:0 0 84214528 2312 1 2 4 7 60.为什么会这样?
I'm trying to make an universal bubble sort function. It allow to user to write its own compare and swap function. I implemented a swap and compare function for int type, but when I run the code for next array: {3, 5, 8, 9, 1, 2, 4, 7, 6, 0} , I get: 0 0 84214528 2312 1 2 4 7 6 0. Why this is happening?
#include <stdio.h>
#include <stdlib.h>
#define true 1
#define false 0
int compInt(void *a, void *b) // FUNCTION FOR COMPARE INT
{
if (*(int*)(a) > *(int*)(b)) { return false; } // IF FIRST INT > SECOND INT (WRONG ORDER) RETURN FALSE
return true; // RIGHT ORDER -> RETURN TRUE
}
我认为问题出在swapInt中.
I think the problem is somewhere in swapInt.
void swapInt(void *a, void *b) // FUNCTION FOR SWAP INT
{
int aux; // TEMPORARY VARIABLE, IT STORAGES VALUE OF *(int*)(a)
aux = *(int*)(a);
*(int*)(a) = *(int*)(b); // a value is now equal to b value
*(int*)(b) = aux; // b has value of aux
}
void bubbleSort(void *address, int len, int (*comp)(void *a, void *b), void (*swap)(void *a, void *b)) // bubble sort function allow to user to write it's compare and swap function
{
int newlen;
while (len != 0) {
newlen = 0;
for (int i = 1; i < len; i++) {
if (!comp(address + i - 1, address + i)) {
swap(address + i - 1, address + i);
newlen = i;
}
}
len = newlen;
}
}
int main()
{
int array[] = {3, 5, 8, 9, 1, 2, 4, 7, 6, 0}; // CREATE AN ARRAY OF INT
int len = 10; // DECLARE IT LEN
void *address; // VOID POINTER TO ARRAY
address = array;
bubbleSort(address, len, &compInt, &swapInt); // SORT IT
for (int i = 0; i < len; ++i) {
printf("%d ", array[i]); // PRINT IT
}
return 0;
}
感谢帮助!
推荐答案
感谢@ mephi42.这是更新版本.
Thanks @mephi42. Here's the update version.
问题出在您的bubbleSort
函数中.您应该在address
上加上偏移量乘以元素大小.
The problem is in your bubbleSort
function. You should add the address
with the offset multiplied by element size.
正确的代码应为:
void bubbleSort(void *address, int len, size_t ele_size, int (*comp)(void *a, void *b), void (*swap)(void *a, void *b)) // bubble sort function allow to user to write it's compare and swap function
{
int newlen;
while (len != 0) {
newlen = 0;
for (int i = 1; i < len; i++) {
if (!comp((char*)address + ele_size * (i - 1), (char*)address + ele_size * i)) {
swap((char*)address + ele_size * (i - 1), (char*)address + ele_size * i);
newlen = i;
}
}
len = newlen;
}
}
然后调用如下函数:
bubbleSort(address, len, sizeof(int), compInt, &swapInt);
这篇关于C语言中的冒泡排序通用实现的文章就介绍到这了,希望我们推荐的答案对大家有所帮助,也希望大家多多支持IT屋!