带有if-else语句的不同设计决策 [英] Different design decisions with if-else-statements

问题描述

您希望使用以下哪项:

    SomeEnum enum = SomeEnum.SOMETHING;
    if (aString.equals(anotherString)) {
        enum = SomeEnum.SOMETHING_ELSE;
    }
    return foo.bar(enum);

或

    if (aString.equals(anotherString)) {
        return foo.bar(SomeEnum.SOMETHING_ELSE);
    }
    return foo.bar(SomeEnum.SOMETHING);

我认为我更喜欢第一个，因为它只有一个回报点.另一方面，我认为第二个更容易阅读.你怎么认为?也许您有一个更完善的解决方案.

I think I would prefer the first one, because it only has 1 point of return. On the other side I think that the second one is easier to read. What do you think? Maybe you got an even more sophisticated solution.

推荐答案

这取决于我们要讨论的项目:

That depends on how many items we are talking about:

对于较大的枚举，我将保留从String到枚举Object的映射.然后我会在地图上查找该项目，并默认提供SomeEnum.SOMETHING.

For a large enum, I would keep a map from String to enum Object. And I would look up the item in the map and provide SomeEnum.SOMETHING as default.

public SomeEnum get(String key, SomeEnum defaultValue){
    SomeEnum value = this.map.get(key);
    return value == null ? defaultValue : value;
}

对于更少的项目，我可能会使用switch语句:

For fewer items, I'd probably go with a switch statement:

public SomeEnum get(String key, SomeEnum defaultValue){
    switch(key){
        case "somevalue1" : return SomeEnum.SOME_VALUE_1;
        case "somevalue2" : return SomeEnum.SOME_VALUE_2;
        default: return defaultValue;
    }
}

但是，如果实际上只是问题中提到的两个案例，我会同意

But if it's actually just the two cases mentioned in the question, I'd go with

return aString.equals(anotherString) ? SomeEnum.SOMETHING_ELSE : SomeEnum.SOMETHING;

这篇关于带有if-else语句的不同设计决策的文章就介绍到这了，希望我们推荐的答案对大家有所帮助，也希望大家多多支持IT屋！