阅读SQL来的DataSet的XmlDocument [英] Reading SQL to DataSet to XmlDocument

问题描述

下面的代码工作梦幻般的。但它可以被制造得更紧凑和C＃'十岁上下？特别是我有一个关于两个问题的怀疑。

1. 是不是丑陋（旧C风格的）灌装填写通过使用它作为一个在参数？


2. 的变量可以将代码进行，而不是通过一个字符串会更紧凑？

C＃

 字符串
的connectionString =...，
的SQL​​Statement =SELECT * FROM测试，
输出=; 
 
 SqlDataAdapter的适配器=新SqlDataAdapter的（的SQLStatement，的connectionString）; 
 DataSet中的DataSet =新的DataSet（目录）; 
 adapter.Fill（DataSet中，测试）; 
的StringWriter的StringWriter =新的StringWriter（）; 
 dataSet.WriteXml（新的XmlTextWriter（StringWriter的））; 
的XmlDocument文档=新的XmlDocument（）; 
输出= stringWriter.ToString（）; 
 document.LoadXml（输出）; 
  

解决方案

我不知道使它更加C＃ ISH或小巧，但你需要关闭适配器和StringWriter的。我会使用使用块。

 字符串
的connectionString =...，
的SQLStatement =从测试选择*， 
输出=; 
 
 DataSet中的DataSet =新的DataSet（目录）;使用
（SqlDataAdapter的适配器=新SqlDataAdapter的（的SQLStatement，的connectionString））{
 adapter.Fill（DataSet中，测试）;}用（StringWriter的StringWriter的=新的StringWriter（））
 $ { b $ b dataSet.WriteXml（新的XmlTextWriter（StringWriter的））; 
输出= stringWriter.ToString（）; 
}; 
的XmlDocument文档=新的XmlDocument（）; 
 document.LoadXml（输出）; 
  

The code below works dreamy. But can it be made more compact and C#'ish? Especially i have suspicions regarding two issues.

1. Isn't it ugly (old C-style) filling fill a variable by using it as a in-parameter?
2. Can the code be made more compact instead of going through a String?

C#

String
  connectionString = "...",
  sqlStatement = "select * from Test",
  output = "";

SqlDataAdapter adapter = new SqlDataAdapter(sqlStatement, connectionString);
DataSet dataSet = new DataSet("Contents");
adapter.Fill(dataSet, "Test");
StringWriter stringWriter=new StringWriter();
dataSet.WriteXml(new XmlTextWriter(stringWriter));
XmlDocument document = new XmlDocument();
output = stringWriter.ToString();
document.LoadXml(output);

解决方案

I don't know about making it more C#ish or compact, but you do need to close your Adapter and StringWriter. I would use the using block.

   String
       connectionString = "...",
       sqlStatement = "select * from Test",
       output = "";

    DataSet dataSet = new DataSet("Contents");
    using (SqlDataAdapter adapter = new SqlDataAdapter(sqlStatement, connectionString)){
        adapter.Fill(dataSet, "Test");}
    using (StringWriter stringWriter = new StringWriter()) { 
      dataSet.WriteXml(new XmlTextWriter(stringWriter));
      output = stringWriter.ToString();
    };
    XmlDocument document = new XmlDocument();
    document.LoadXml(output);

这篇关于阅读SQL来的DataSet的XmlDocument的文章就介绍到这了，希望我们推荐的答案对大家有所帮助，也希望大家多多支持IT屋！