里面的ExecuteNonQuery循环 [英] ExecuteNonQuery inside loop

问题描述

我试图插入在C＃循环中有一个数据库记录

I'm trying to insert a database record inside a loop in C#.

它工作时，我很难这样的代码值：

It works when I hard code the values like this:

    string query3 = "INSERT INTO furniture (room_id,member_id) VALUES (222,333);";
    SqlCommand cmd3 = new SqlCommand(query3, sqlConnection3);
    sqlConnection3.Open();

    for (int i = 0; i < arrItemsPlanner.Length; i++)
    {
        try
            {
                cmd3.ExecuteNonQuery();
            }
            catch
            {
                return "Error: Item could not be saved";
            }
            finally
            {
                //Fail
            }
        }

但是当我使用参数化查询，这是行不通的 - 即使我硬编码一个值这样的参数化查询：

But when I use parameterised queries it doesn't work - even if I hard code a value into the parameterised query like this:

    string query3 = "INSERT INTO furniture (room_id,member_id) VALUES (@room_id,333);";
    SqlCommand cmd3 = new SqlCommand(query3, sqlConnection3);
    sqlConnection3.Open();

    for (int i = 0; i < arrItemsPlanner.Length; i++)
    {
        try
            {
                cmd3.Parameters.Add("@room_id", System.Data.SqlDbType.Int);
                cmd3.Parameters["@room_id"].Value = 222;
                cmd3.ExecuteNonQuery();
            }
            catch
            {
                return "Error: Item could not be saved";
            }
            finally
            {
                //Fail
            }
        }

任何人都可以看到我要去哪里错在这里？

Can anyone see where I'm going wrong here?

非常感谢！

推荐答案

它看起来像你一遍又一遍增加了命令的参数集合。在每次迭代清除它。

It looks like you are adding to the command's parameter collection over and over. Clear it with each iteration.

我也建议抛出的实际的异常，所以你可以看到的问题是什么。

I would also suggest throwing the actual exception so you can see what the problem is.

这篇关于里面的ExecuteNonQuery循环的文章就介绍到这了，希望我们推荐的答案对大家有所帮助，也希望大家多多支持IT屋！