Android的错误 - 关闭()从来没有明确要求数据库 [英] Android error - close() was never explicitly called on database
问题描述
如果调用close()在code?
在LogCat中返回此错误:
close()方法从未明确要求数据库 android.database.sqlite.DatabaseObjectNotClosedException:应用程序没有关闭在这里打开的游标或数据库对象
该错误是这样的:
> 12-16 17:24:50.886:ERROR /数据库(10982):关闭()从来没有明确要求数据库/data/data/com.psyhclo/databases/calls.db
12-16 17:24:50.886:ERROR /数据库(10982):android.database.sqlite.DatabaseObjectNotClosedException:应用程序没有关闭在这里打开的游标或数据库对象
12-16 17:24:50.886:ERROR /数据库(10982):在android.database.sqlite.SQLiteDatabase< INIT>(SQLiteDatabase.java:1827)。
12-16 17:24:50.886:ERROR /数据库(10982):在android.database.sqlite.SQLiteDatabase.openDatabase(SQLiteDatabase.java:820)
12-16 17:24:50.886:ERROR /数据库(10982):在android.database.sqlite.SQLiteDatabase.openOrCreateDatabase(SQLiteDatabase.java:854)
12-16 17:24:50.886:ERROR /数据库(10982):在android.database.sqlite.SQLiteDatabase.openOrCreateDatabase(SQLiteDatabase.java:847)
12-16 17:24:50.886:ERROR /数据库(10982):在android.app.ContextImpl.openOrCreateDatabase(ContextImpl.java:541)
12-16 17:24:50.886:ERROR /数据库(10982):在android.content.ContextWrapper.openOrCreateDatabase(ContextWrapper.java:203)
12-16 17:24:50.886:ERROR /数据库(10982):在android.database.sqlite.SQLiteOpenHelper.getWritableDatabase(SQLiteOpenHelper.java:118)
12-16 17:24:50.886:ERROR /数据库(10982):在com.psyhclo.CallDataHelper< INIT>(CallDataHelper.java:27)。
12-16 17:24:50.886:ERROR /数据库(10982):在com.psyhclo.RatedCalls.fillList(RatedCalls.java:66)
12-16 17:24:50.886:ERROR /数据库(10982):在com.psyhclo.RatedCalls.access $ 0(RatedCalls.java:63)
12-16 17:24:50.886:ERROR /数据库(10982):在com.psyhclo.RatedCalls $ RatedCallsContentObserver.onChange(RatedCalls.java:58)
12-16 17:24:50.886:ERROR /数据库(10982):在android.database.ContentObserver $ NotificationRunnable.run(ContentObserver.java:43)
12-16 17:24:50.886:ERROR /数据库(10982):在android.os.Handler.handleCallback(Handler.java:587)
12-16 17:24:50.886:ERROR /数据库(10982):在android.os.Handler.dispatchMessage(Handler.java:92)
12-16 17:24:50.886:ERROR /数据库(10982):在android.os.Looper.loop(Looper.java:123)
12-16 17:24:50.886:ERROR /数据库(10982):在android.app.ActivityThread.main(ActivityThread.java:3647)
12-16 17:24:50.886:ERROR /数据库(10982):在java.lang.reflect.Method.invokeNative(本机方法)
12-16 17:24:50.886:ERROR /数据库(10982):在java.lang.reflect.Method.invoke(Method.java:507)
12-16 17:24:50.886:ERROR /数据库(10982):在com.android.internal.os.ZygoteInit $ MethodAndArgsCaller.run(ZygoteInit.java:839)
12-16 17:24:50.886:ERROR /数据库(10982):在com.android.internal.os.ZygoteInit.main(ZygoteInit.java:597)
12-16 17:24:50.886:ERROR /数据库(10982):在dalvik.system.NativeStart.main(本机方法)
这是我的code。
的活动:
公共类RatedCalls扩展ListActivity {
私有静态最后弦乐LOG_TAG =RATEDCALLSOBSERVER;
私人处理程序处理程序=新的处理程序();
私人SQLiteDatabase分贝;
私人CallDataHelper CDH;
StringBuilder的SB =新的StringBuilder();
OpenHelper openHelper =新OpenHelper(RatedCalls.this);
@覆盖
公共无效的onCreate(包savedInstanceState){
super.onCreate(savedInstanceState);
registerContentObservers();
Log.d(FILLLIST,来自的onCreate()调用);
}
类RatedCallsContentObserver扩展ContentObserver {
公共RatedCallsContentObserver(处理器高){
超(H);
}
@覆盖
公共布尔deliverSelfNotifications(){
返回true;
}
@覆盖
公共无效的onChange(布尔selfChange){
Log.d(LOG_TAG,RatedCallsContentObserver.onChange(+ selfChange
+));
super.onChange(selfChange);
fillList();
的onStop();
}
}
私人无效fillList(){
DB = openHelper.getWritableDatabase();
鼎晖=新CallDataHelper(本);
串lastDate = cdh.selectDate();
光标光标= getContentResolver()查询(
android.provider.CallLog.Calls.CONTENT_URI,空,
android.provider.CallLog.Calls.DATE +&所述;?,
新的String [] {} lastDate,
android.provider.CallLog.Calls.DATE +降序);
Log.d(FILLLIST,从filllist调用);
startManagingCursor(光标);
INT numberColumnId =光标
.getColumnIndex(android.provider.CallLog.Calls.NUMBER);
INT durationId =光标
.getColumnIndex(android.provider.CallLog.Calls.DURATION);
INT contactNameId =光标
.getColumnIndex(android.provider.CallLog.Calls.CACHED_NAME);
INT numTypeId =光标
.getColumnIndex(android.provider.CallLog.Calls.CACHED_NUMBER_TYPE);
日期DT =新的日期();
INT小时= dt.getHours();
INT分钟= dt.getMinutes();
INT秒= dt.getSeconds();
串currTime =小时+:+分钟+:+秒;
SimpleDateFormat的日期格式=新的SimpleDateFormat(MM-DD-YYYY);
日期日期=新的日期();
ArrayList的<字符串>呼叫清单=新的ArrayList<字符串>();
cursor.moveToFirst();
字符串contactNumber = cursor.getString(numberColumnId);
字符串CONTACTNAME = cursor.getString(contactNameId);
字符串长度= cursor.getString(durationId);
//字符串callDate = DateFormat.getDateInstance()格式(dateId);
字符串numType = cursor.getString(numTypeId);
ContentValues值=新ContentValues();
values.put(CONTACT_ID,1);
values.put(CONTACT_NAME,联系人姓名);
values.put(NUMBER_TYPE,numType);
values.put(contact_number,contactNumber);
values.put(持续时间,持续时间);
values.put(日期,dateFormat.format(日期));
values.put(CURRENT_TIME,currTime);
values.put(CONT,1);
getBaseContext()。getContentResolver()。有NotifyChange(
android.provider.CallLog.Calls.CONTENT_URI,
新RatedCallsContentObserver(处理));
db.insert(CallDataHelper.TABLE_NAME,空,价值观);
Toast.makeText(getBaseContext(),插入!,Toast.LENGTH_LONG);
callList.add(联络号码:+ contactNumber +\ n请联系名字:
+联系人姓名+\ nDuration:+时间+\ nDate:
+ dateFormat.format(日期));
setListAdapter(新ArrayAdapter<字符串>(这一点,R.layout.listitem,
呼叫清单));
ListView的LV = getListView();
lv.setTextFilterEnabled(真正的);
lv.setOnItemClickListener(新android.widget.AdapterView.OnItemClickListener(){
@覆盖
公共无效onItemClick(适配器视图<>母公司视图中查看,
INT位置,长的id){
Toast.makeText(getApplicationContext(),
((TextView中)查看).getText(),Toast.LENGTH_SHORT).show();
}
});
}
公共无效registerContentObservers(){
this.getApplicationContext()
.getContentResolver()
.registerContentObserver(
android.provider.CallLog.Calls.CONTENT_URI,真实,
新RatedCallsContentObserver(处理));
}
公共无效unregisterContentObservers(){
this.getApplicationContext()
.getContentResolver()
.unregisterContentObserver(
新RatedCallsContentObserver(处理));
}
}
而DatabaseHelper
公共类CallDataHelper {
私有静态最后弦乐DATABASE_NAME =calls.db;
私有静态最终诠释DATABASE_VERSION = 1;
受保护的静态最后弦乐TABLE_NAME =contact_data;
私人上下文的背景下;
私人SQLiteDatabase分贝;
公共CallDataHelper(上下文的背景下){
this.context =背景;
OpenHelper openHelper =新OpenHelper(this.context);
this.db = openHelper.getWritableDatabase();
}
公共布尔插入(CID整数,字符串CNAME,字符串numType,
字符串CNUM,字符串DUR,字符串日期,字符串currTime){
this.db.execSQL(插入
+ TABLE_NAME
+(CONTACT_ID,CONTACT_NAME,NUMBER_TYPE,contact_number,时间,日期,CURRENT_TIME,续)
+的值(+ CID +,+ CNAME +,+ numType +,
+ CNUM +,+ DUR +,+日期+,+ currTime +,1));
返回true;
}
公共无效更新(字符串字){
this.db.execSQL(更新字数设置续=续+ 1 WHERE(字=?),
新的String [] {文字});
}
公共无效用deleteAll(){
this.db.delete(TABLE_NAME,NULL,NULL);
}
公共字符串selectDate(){
字符串日=;
光标光标= this.db.query(TABLE_NAME,新的String [] {日期},
?ID =,新的String [] {MAX(ID)},NULL,NULL,NULL);
如果(cursor.moveToFirst()){
做 {
日期= cursor.getString(0);
}而(cursor.moveToNext());
}
如果(光标=空&安培;!&安培;!cursor.isClosed()){
cursor.close();
返回日期;
} 其他 {
返回 ;
}
}
公开名单<字符串>全选() {
名单<字符串>名单=新的ArrayList<字符串>();
光标光标= this.db.query(TABLE_NAME,新的String [] {字},
NULL,NULL,NULL,NULL,续递减);
如果(cursor.moveToFirst()){
做 {
list.add(cursor.getString(0).toUpperCase());
}而(cursor.moveToNext());
}
如果(光标=空&安培;!&安培;!cursor.isClosed()){
cursor.close();
}
返回列表;
}
公共静态类OpenHelper扩展SQLiteOpenHelper {
OpenHelper(上下文的背景下){
超(背景下,DATABASE_NAME,空,DATABASE_VERSION);
}
@覆盖
公共无效的onCreate(SQLiteDatabase DB){
db.execSQL(CREATE TABLE
+ TABLE_NAME
+(ID INTEGER PRIMARY KEY AUTOINCREMENT,CONTACT_ID INTEGER,CONTACT_NAME VARCHAR(50),NUMBER_TYPE VARCHAR(50),contact_number VARCHAR(50),持续时间,日期DATE,TIME CURRENT_TIME,续INTEGER));
}
@覆盖
公共无效onUpgrade(SQLiteDatabase分贝,INT oldVersion,诠释静态网页){
Log.w(RatedCalls数据库,
升级数据库,这将删除表并重新创建。);
db.execSQL(DROP TABLE IF EXISTS+ TABLE_NAME);
的onCreate(DB);
}
}
}
_ 的___的(编辑) __ _ 的____
这是我现在得到。当我提出一个新的呼叫时,logcat中返回这一点。
12-16 18:55:27.365:ERROR / AndroidRuntime(767):致命异常:主要
12-16 18:55:27.365:ERROR / AndroidRuntime(767):java.lang.IllegalStateException:数据库无法打开
12-16 18:55:27.365:ERROR / AndroidRuntime(767):在android.database.sqlite.SQLiteDatabase.queryWithFactory(SQLiteDatabase.java:1230)
12-16 18:55:27.365:ERROR / AndroidRuntime(767):在android.database.sqlite.SQLiteDatabase.query(SQLiteDatabase.java:1189)
12-16 18:55:27.365:ERROR / AndroidRuntime(767):在android.database.sqlite.SQLiteDatabase.query(SQLiteDatabase.java:1271)
12-16 18:55:27.365:ERROR / AndroidRuntime(767):在com.psyhclo.CallDataHelper.selectDate(CallDataHelper.java:61)
12-16 18:55:27.365:ERROR / AndroidRuntime(767):在com.psyhclo.RatedCalls.fillList(RatedCalls.java:98)
12-16 18:55:27.365:ERROR / AndroidRuntime(767):在com.psyhclo.RatedCalls.access $ 0(RatedCalls.java:96)
12-16 18:55:27.365:ERROR / AndroidRuntime(767):在com.psyhclo.RatedCalls $ RatedCallsContentObserver.onChange(RatedCalls.java:91)
12-16 18:55:27.365:ERROR / AndroidRuntime(767):在android.database.ContentObserver $ NotificationRunnable.run(ContentObserver.java:43)
12-16 18:55:27.365:ERROR / AndroidRuntime(767):在android.os.Handler.handleCallback(Handler.java:587)
12-16 18:55:27.365:ERROR / AndroidRuntime(767):在android.os.Handler.dispatchMessage(Handler.java:92)
12-16 18:55:27.365:ERROR / AndroidRuntime(767):在android.os.Looper.loop(Looper.java:123)
12-16 18:55:27.365:ERROR / AndroidRuntime(767):在android.app.ActivityThread.main(ActivityThread.java:3647)
12-16 18:55:27.365:ERROR / AndroidRuntime(767):在java.lang.reflect.Method.invokeNative(本机方法)
12-16 18:55:27.365:ERROR / AndroidRuntime(767):在java.lang.reflect.Method.invoke(Method.java:507)
12-16 18:55:27.365:ERROR / AndroidRuntime(767):在com.android.internal.os.ZygoteInit $ MethodAndArgsCaller.run(ZygoteInit.java:839)
12-16 18:55:27.365:ERROR / AndroidRuntime(767):在com.android.internal.os.ZygoteInit.main(ZygoteInit.java:597)
12-16 18:55:27.365:ERROR / AndroidRuntime(767):在dalvik.system.NativeStart.main(本机方法)
这是我的活动:
公共类RatedCalls扩展ListActivity {
私有静态最后弦乐LOG_TAG =RATEDCALLSOBSERVER;
私人处理程序处理程序=新的处理程序();
私人SQLiteDatabase分贝;
私人CallDataHelper CDH;
StringBuilder的SB =新的StringBuilder();
OpenHelper openHelper =新OpenHelper(RatedCalls.this);
@覆盖
公共无效的onCreate(包savedInstanceState){
super.onCreate(savedInstanceState);
registerContentObservers();
Log.d(FILLLIST,来自的onCreate()调用);
鼎晖=新CallDataHelper(本);
DB = openHelper.getWritableDatabase();
}
@覆盖
保护无效的onDestroy(){
super.onDestroy();
如果(openHelper!= NULL){
openHelper.close();
}
如果(CDH!= NULL){
cdh.close();
}
}
@覆盖
保护无效的onPause(){
super.onPause();
如果(openHelper!= NULL){
openHelper.close();
}
如果(CDH!= NULL){
cdh.close();
}
}
@覆盖
公共无效onResume(){
super.onResume();
openOrCreateDatabase(calls.db,SQLiteDatabase.CREATE_IF_NECESSARY,
空值);
}
类RatedCallsContentObserver扩展ContentObserver {
公共RatedCallsContentObserver(处理器高){
超(H);
}
@覆盖
公共布尔deliverSelfNotifications(){
返回true;
}
@覆盖
公共无效的onChange(布尔selfChange){
Log.d(LOG_TAG,RatedCallsContentObserver.onChange(+ selfChange
+));
super.onChange(selfChange);
fillList();
}
}
私人无效fillList(){
串lastDate = cdh.selectDate();
光标光标= getContentResolver()查询(
android.provider.CallLog.Calls.CONTENT_URI,空,
android.provider.CallLog.Calls.DATE +&所述;?,
新的String [] {} lastDate,
android.provider.CallLog.Calls.DATE +降序);
Log.d(FILLLIST,从filllist调用);
startManagingCursor(光标);
INT numberColumnId =光标
.getColumnIndex(android.provider.CallLog.Calls.NUMBER);
INT durationId =光标
.getColumnIndex(android.provider.CallLog.Calls.DURATION);
INT contactNameId =光标
.getColumnIndex(android.provider.CallLog.Calls.CACHED_NAME);
INT numTypeId =光标
.getColumnIndex(android.provider.CallLog.Calls.CACHED_NUMBER_TYPE);
日期DT =新的日期();
INT小时= dt.getHours();
INT分钟= dt.getMinutes();
INT秒= dt.getSeconds();
串currTime =小时+:+分钟+:+秒;
SimpleDateFormat的日期格式=新的SimpleDateFormat(MM-DD-YYYY);
日期日期=新的日期();
ArrayList的<字符串>呼叫清单=新的ArrayList<字符串>();
cursor.moveToFirst();
字符串contactNumber = cursor.getString(numberColumnId);
字符串CONTACTNAME = cursor.getString(contactNameId);
字符串长度= cursor.getString(durationId);
//字符串callDate = DateFormat.getDateInstance()格式(dateId);
字符串numType = cursor.getString(numTypeId);
stopManagingCursor(光标);
ContentValues值=新ContentValues();
values.put(CONTACT_ID,1);
values.put(CONTACT_NAME,联系人姓名);
values.put(NUMBER_TYPE,numType);
values.put(contact_number,contactNumber);
values.put(持续时间,持续时间);
values.put(日期,dateFormat.format(日期));
values.put(CURRENT_TIME,currTime);
values.put(CONT,1);
getBaseContext()。getContentResolver()。有NotifyChange(
android.provider.CallLog.Calls.CONTENT_URI,
新RatedCallsContentObserver(处理));
db.insert(CallDataHelper.TABLE_NAME,空,价值观);
Toast.makeText(getBaseContext(),插入!,Toast.LENGTH_LONG);
callList.add(联络号码:+ contactNumber +\ n请联系名字:
+联系人姓名+\ nDuration:+时间+\ nDate:
+ dateFormat.format(日期));
setListAdapter(新ArrayAdapter<字符串>(这一点,R.layout.listitem,
呼叫清单));
ListView的LV = getListView();
lv.setTextFilterEnabled(真正的);
lv.setOnItemClickListener(新android.widget.AdapterView.OnItemClickListener(){
@覆盖
公共无效onItemClick(适配器视图<>母公司视图中查看,
INT位置,长的id){
Toast.makeText(getApplicationContext(),
((TextView中)查看).getText(),Toast.LENGTH_SHORT).show();
}
});
}
公共无效registerContentObservers(){
this.getApplicationContext()
.getContentResolver()
.registerContentObserver(
android.provider.CallLog.Calls.CONTENT_URI,真实,
新RatedCallsContentObserver(处理));
}
公共无效unregisterContentObservers(){
this.getApplicationContext()
.getContentResolver()
.unregisterContentObserver(
新RatedCallsContentObserver(处理));
}
}
我认为这个问题是,你需要关闭该数据库时,你的活动被破坏。尝试添加到您的活动:
@覆盖
保护无效的onDestroy(){
super.onDestroy();
如果(openHelper!= NULL){
openHelper.close();
}
如果(CDH!= NULL){
cdh.close();
}
}
和添加到您的CallDataHelper类:
公共无效的close(){
//注意:现在openHelper必须CallDataHelper的成员;
//你现在把它作为一个地方在构造函数
如果(openHelper!= NULL){
openHelper.close();
}
}
编辑2:同时改变CallDataHelper构造函数:
//声明openHelper作为成员变量
OpenHelper openHelper = NULL;
公共CallDataHelper(上下文的背景下){
this.context =背景;
openHelper =新OpenHelper(this.context);
this.db = openHelper.getWritableDatabase();
}
这应该成功关闭由双方你 OpenHelper
实例创建的数据库连接。
( EDITED ,以反映您使用两个OpenHelper实例的事实。)
Where should I call close() on the code?
The LogCat returns this error:
close() was never explicitly called on database android.database.sqlite.DatabaseObjectNotClosedException: Application did not close the cursor or database object that was opened here
The error is this:
> 12-16 17:24:50.886: ERROR/Database(10982): close() was never explicitly called on database '/data/data/com.psyhclo/databases/calls.db'
12-16 17:24:50.886: ERROR/Database(10982): android.database.sqlite.DatabaseObjectNotClosedException: Application did not close the cursor or database object that was opened here
12-16 17:24:50.886: ERROR/Database(10982): at android.database.sqlite.SQLiteDatabase.<init>(SQLiteDatabase.java:1827)
12-16 17:24:50.886: ERROR/Database(10982): at android.database.sqlite.SQLiteDatabase.openDatabase(SQLiteDatabase.java:820)
12-16 17:24:50.886: ERROR/Database(10982): at android.database.sqlite.SQLiteDatabase.openOrCreateDatabase(SQLiteDatabase.java:854)
12-16 17:24:50.886: ERROR/Database(10982): at android.database.sqlite.SQLiteDatabase.openOrCreateDatabase(SQLiteDatabase.java:847)
12-16 17:24:50.886: ERROR/Database(10982): at android.app.ContextImpl.openOrCreateDatabase(ContextImpl.java:541)
12-16 17:24:50.886: ERROR/Database(10982): at android.content.ContextWrapper.openOrCreateDatabase(ContextWrapper.java:203)
12-16 17:24:50.886: ERROR/Database(10982): at android.database.sqlite.SQLiteOpenHelper.getWritableDatabase(SQLiteOpenHelper.java:118)
12-16 17:24:50.886: ERROR/Database(10982): at com.psyhclo.CallDataHelper.<init>(CallDataHelper.java:27)
12-16 17:24:50.886: ERROR/Database(10982): at com.psyhclo.RatedCalls.fillList(RatedCalls.java:66)
12-16 17:24:50.886: ERROR/Database(10982): at com.psyhclo.RatedCalls.access$0(RatedCalls.java:63)
12-16 17:24:50.886: ERROR/Database(10982): at com.psyhclo.RatedCalls$RatedCallsContentObserver.onChange(RatedCalls.java:58)
12-16 17:24:50.886: ERROR/Database(10982): at android.database.ContentObserver$NotificationRunnable.run(ContentObserver.java:43)
12-16 17:24:50.886: ERROR/Database(10982): at android.os.Handler.handleCallback(Handler.java:587)
12-16 17:24:50.886: ERROR/Database(10982): at android.os.Handler.dispatchMessage(Handler.java:92)
12-16 17:24:50.886: ERROR/Database(10982): at android.os.Looper.loop(Looper.java:123)
12-16 17:24:50.886: ERROR/Database(10982): at android.app.ActivityThread.main(ActivityThread.java:3647)
12-16 17:24:50.886: ERROR/Database(10982): at java.lang.reflect.Method.invokeNative(Native Method)
12-16 17:24:50.886: ERROR/Database(10982): at java.lang.reflect.Method.invoke(Method.java:507)
12-16 17:24:50.886: ERROR/Database(10982): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:839)
12-16 17:24:50.886: ERROR/Database(10982): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:597)
12-16 17:24:50.886: ERROR/Database(10982): at dalvik.system.NativeStart.main(Native Method)
here is my code.
The Activity:
public class RatedCalls extends ListActivity {
private static final String LOG_TAG = "RATEDCALLSOBSERVER";
private Handler handler = new Handler();
private SQLiteDatabase db;
private CallDataHelper cdh;
StringBuilder sb = new StringBuilder();
OpenHelper openHelper = new OpenHelper(RatedCalls.this);
@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
registerContentObservers();
Log.d("FILLLIST", "calling from onCreate()");
}
class RatedCallsContentObserver extends ContentObserver {
public RatedCallsContentObserver(Handler h) {
super(h);
}
@Override
public boolean deliverSelfNotifications() {
return true;
}
@Override
public void onChange(boolean selfChange) {
Log.d(LOG_TAG, "RatedCallsContentObserver.onChange( " + selfChange
+ ")");
super.onChange(selfChange);
fillList();
onStop();
}
}
private void fillList() {
db = openHelper.getWritableDatabase();
cdh = new CallDataHelper(this);
String lastDate = cdh.selectDate();
Cursor cursor = getContentResolver().query(
android.provider.CallLog.Calls.CONTENT_URI, null,
android.provider.CallLog.Calls.DATE + " < ?",
new String[] { lastDate },
android.provider.CallLog.Calls.DATE + " DESC ");
Log.d("FILLLIST", "Calling from filllist");
startManagingCursor(cursor);
int numberColumnId = cursor
.getColumnIndex(android.provider.CallLog.Calls.NUMBER);
int durationId = cursor
.getColumnIndex(android.provider.CallLog.Calls.DURATION);
int contactNameId = cursor
.getColumnIndex(android.provider.CallLog.Calls.CACHED_NAME);
int numTypeId = cursor
.getColumnIndex(android.provider.CallLog.Calls.CACHED_NUMBER_TYPE);
Date dt = new Date();
int hours = dt.getHours();
int minutes = dt.getMinutes();
int seconds = dt.getSeconds();
String currTime = hours + ":" + minutes + ":" + seconds;
SimpleDateFormat dateFormat = new SimpleDateFormat("MM-dd-yyyy");
Date date = new Date();
ArrayList<String> callList = new ArrayList<String>();
cursor.moveToFirst();
String contactNumber = cursor.getString(numberColumnId);
String contactName = cursor.getString(contactNameId);
String duration = cursor.getString(durationId);
// String callDate = DateFormat.getDateInstance().format(dateId);
String numType = cursor.getString(numTypeId);
ContentValues values = new ContentValues();
values.put("contact_id", 1);
values.put("contact_name", contactName);
values.put("number_type", numType);
values.put("contact_number", contactNumber);
values.put("duration", duration);
values.put("date", dateFormat.format(date));
values.put("current_time", currTime);
values.put("cont", 1);
getBaseContext().getContentResolver().notifyChange(
android.provider.CallLog.Calls.CONTENT_URI,
new RatedCallsContentObserver(handler));
db.insert(CallDataHelper.TABLE_NAME, null, values);
Toast.makeText(getBaseContext(), "Inserted!", Toast.LENGTH_LONG);
callList.add("Contact Number: " + contactNumber + "\nContact Name: "
+ contactName + "\nDuration: " + duration + "\nDate: "
+ dateFormat.format(date));
setListAdapter(new ArrayAdapter<String>(this, R.layout.listitem,
callList));
ListView lv = getListView();
lv.setTextFilterEnabled(true);
lv.setOnItemClickListener(new android.widget.AdapterView.OnItemClickListener() {
@Override
public void onItemClick(AdapterView<?> parent, View view,
int position, long id) {
Toast.makeText(getApplicationContext(),
((TextView) view).getText(), Toast.LENGTH_SHORT).show();
}
});
}
public void registerContentObservers() {
this.getApplicationContext()
.getContentResolver()
.registerContentObserver(
android.provider.CallLog.Calls.CONTENT_URI, true,
new RatedCallsContentObserver(handler));
}
public void unregisterContentObservers() {
this.getApplicationContext()
.getContentResolver()
.unregisterContentObserver(
new RatedCallsContentObserver(handler));
}
}
And the DatabaseHelper
public class CallDataHelper {
private static final String DATABASE_NAME = "calls.db";
private static final int DATABASE_VERSION = 1;
protected static final String TABLE_NAME = "contact_data";
private Context context;
private SQLiteDatabase db;
public CallDataHelper(Context context) {
this.context = context;
OpenHelper openHelper = new OpenHelper(this.context);
this.db = openHelper.getWritableDatabase();
}
public boolean insert(Integer cId, String cName, String numType,
String cNum, String dur, String date, String currTime) {
this.db.execSQL("insert into "
+ TABLE_NAME
+ " (contact_id, contact_name, number_type, contact_number, duration, date, current_time, cont) "
+ " values( " + cId + ", " + cName + ", " + numType + ", "
+ cNum + ", " + dur + ", " + date + ", " + currTime + ", 1)");
return true;
}
public void update(String word) {
this.db.execSQL("UPDATE words SET cont = cont + 1 WHERE (word= ?)",
new String[] { word });
}
public void deleteAll() {
this.db.delete(TABLE_NAME, null, null);
}
public String selectDate() {
String date = "";
Cursor cursor = this.db.query(TABLE_NAME, new String[] { "date" },
"id = ?", new String[] { "max(id)" }, null, null, null);
if (cursor.moveToFirst()) {
do {
date = cursor.getString(0);
} while (cursor.moveToNext());
}
if (cursor != null && !cursor.isClosed()) {
cursor.close();
return date;
} else {
return "";
}
}
public List<String> selectAll() {
List<String> list = new ArrayList<String>();
Cursor cursor = this.db.query(TABLE_NAME, new String[] { "word" },
null, null, null, null, "cont desc");
if (cursor.moveToFirst()) {
do {
list.add(cursor.getString(0).toUpperCase());
} while (cursor.moveToNext());
}
if (cursor != null && !cursor.isClosed()) {
cursor.close();
}
return list;
}
public static class OpenHelper extends SQLiteOpenHelper {
OpenHelper(Context context) {
super(context, DATABASE_NAME, null, DATABASE_VERSION);
}
@Override
public void onCreate(SQLiteDatabase db) {
db.execSQL("CREATE TABLE "
+ TABLE_NAME
+ "(id INTEGER PRIMARY KEY AUTOINCREMENT, contact_id INTEGER, contact_name VARCHAR(50), number_type VARCHAR(50), contact_number VARCHAR(50), duration TIME, date DATE, current_time TIME, cont INTEGER)");
}
@Override
public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) {
Log.w("RatedCalls Database",
"Upgrading database, this will drop tables and recreate.");
db.execSQL("DROP TABLE IF EXISTS " + TABLE_NAME);
onCreate(db);
}
}
}
____(Edited)_______
This is what I get now. When I make a new call, the Logcat returns this.
12-16 18:55:27.365: ERROR/AndroidRuntime(767): FATAL EXCEPTION: main
12-16 18:55:27.365: ERROR/AndroidRuntime(767): java.lang.IllegalStateException: database not open
12-16 18:55:27.365: ERROR/AndroidRuntime(767): at android.database.sqlite.SQLiteDatabase.queryWithFactory(SQLiteDatabase.java:1230)
12-16 18:55:27.365: ERROR/AndroidRuntime(767): at android.database.sqlite.SQLiteDatabase.query(SQLiteDatabase.java:1189)
12-16 18:55:27.365: ERROR/AndroidRuntime(767): at android.database.sqlite.SQLiteDatabase.query(SQLiteDatabase.java:1271)
12-16 18:55:27.365: ERROR/AndroidRuntime(767): at com.psyhclo.CallDataHelper.selectDate(CallDataHelper.java:61)
12-16 18:55:27.365: ERROR/AndroidRuntime(767): at com.psyhclo.RatedCalls.fillList(RatedCalls.java:98)
12-16 18:55:27.365: ERROR/AndroidRuntime(767): at com.psyhclo.RatedCalls.access$0(RatedCalls.java:96)
12-16 18:55:27.365: ERROR/AndroidRuntime(767): at com.psyhclo.RatedCalls$RatedCallsContentObserver.onChange(RatedCalls.java:91)
12-16 18:55:27.365: ERROR/AndroidRuntime(767): at android.database.ContentObserver$NotificationRunnable.run(ContentObserver.java:43)
12-16 18:55:27.365: ERROR/AndroidRuntime(767): at android.os.Handler.handleCallback(Handler.java:587)
12-16 18:55:27.365: ERROR/AndroidRuntime(767): at android.os.Handler.dispatchMessage(Handler.java:92)
12-16 18:55:27.365: ERROR/AndroidRuntime(767): at android.os.Looper.loop(Looper.java:123)
12-16 18:55:27.365: ERROR/AndroidRuntime(767): at android.app.ActivityThread.main(ActivityThread.java:3647)
12-16 18:55:27.365: ERROR/AndroidRuntime(767): at java.lang.reflect.Method.invokeNative(Native Method)
12-16 18:55:27.365: ERROR/AndroidRuntime(767): at java.lang.reflect.Method.invoke(Method.java:507)
12-16 18:55:27.365: ERROR/AndroidRuntime(767): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:839)
12-16 18:55:27.365: ERROR/AndroidRuntime(767): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:597)
12-16 18:55:27.365: ERROR/AndroidRuntime(767): at dalvik.system.NativeStart.main(Native Method)
And this is my activity:
public class RatedCalls extends ListActivity {
private static final String LOG_TAG = "RATEDCALLSOBSERVER";
private Handler handler = new Handler();
private SQLiteDatabase db;
private CallDataHelper cdh;
StringBuilder sb = new StringBuilder();
OpenHelper openHelper = new OpenHelper(RatedCalls.this);
@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
registerContentObservers();
Log.d("FILLLIST", "calling from onCreate()");
cdh = new CallDataHelper(this);
db = openHelper.getWritableDatabase();
}
@Override
protected void onDestroy() {
super.onDestroy();
if (openHelper != null) {
openHelper.close();
}
if (cdh != null) {
cdh.close();
}
}
@Override
protected void onPause() {
super.onPause();
if (openHelper != null) {
openHelper.close();
}
if (cdh != null) {
cdh.close();
}
}
@Override
public void onResume() {
super.onResume();
openOrCreateDatabase("calls.db", SQLiteDatabase.CREATE_IF_NECESSARY,
null);
}
class RatedCallsContentObserver extends ContentObserver {
public RatedCallsContentObserver(Handler h) {
super(h);
}
@Override
public boolean deliverSelfNotifications() {
return true;
}
@Override
public void onChange(boolean selfChange) {
Log.d(LOG_TAG, "RatedCallsContentObserver.onChange( " + selfChange
+ ")");
super.onChange(selfChange);
fillList();
}
}
private void fillList() {
String lastDate = cdh.selectDate();
Cursor cursor = getContentResolver().query(
android.provider.CallLog.Calls.CONTENT_URI, null,
android.provider.CallLog.Calls.DATE + " < ?",
new String[] { lastDate },
android.provider.CallLog.Calls.DATE + " DESC ");
Log.d("FILLLIST", "Calling from filllist");
startManagingCursor(cursor);
int numberColumnId = cursor
.getColumnIndex(android.provider.CallLog.Calls.NUMBER);
int durationId = cursor
.getColumnIndex(android.provider.CallLog.Calls.DURATION);
int contactNameId = cursor
.getColumnIndex(android.provider.CallLog.Calls.CACHED_NAME);
int numTypeId = cursor
.getColumnIndex(android.provider.CallLog.Calls.CACHED_NUMBER_TYPE);
Date dt = new Date();
int hours = dt.getHours();
int minutes = dt.getMinutes();
int seconds = dt.getSeconds();
String currTime = hours + ":" + minutes + ":" + seconds;
SimpleDateFormat dateFormat = new SimpleDateFormat("MM-dd-yyyy");
Date date = new Date();
ArrayList<String> callList = new ArrayList<String>();
cursor.moveToFirst();
String contactNumber = cursor.getString(numberColumnId);
String contactName = cursor.getString(contactNameId);
String duration = cursor.getString(durationId);
// String callDate = DateFormat.getDateInstance().format(dateId);
String numType = cursor.getString(numTypeId);
stopManagingCursor(cursor);
ContentValues values = new ContentValues();
values.put("contact_id", 1);
values.put("contact_name", contactName);
values.put("number_type", numType);
values.put("contact_number", contactNumber);
values.put("duration", duration);
values.put("date", dateFormat.format(date));
values.put("current_time", currTime);
values.put("cont", 1);
getBaseContext().getContentResolver().notifyChange(
android.provider.CallLog.Calls.CONTENT_URI,
new RatedCallsContentObserver(handler));
db.insert(CallDataHelper.TABLE_NAME, null, values);
Toast.makeText(getBaseContext(), "Inserted!", Toast.LENGTH_LONG);
callList.add("Contact Number: " + contactNumber + "\nContact Name: "
+ contactName + "\nDuration: " + duration + "\nDate: "
+ dateFormat.format(date));
setListAdapter(new ArrayAdapter<String>(this, R.layout.listitem,
callList));
ListView lv = getListView();
lv.setTextFilterEnabled(true);
lv.setOnItemClickListener(new android.widget.AdapterView.OnItemClickListener() {
@Override
public void onItemClick(AdapterView<?> parent, View view,
int position, long id) {
Toast.makeText(getApplicationContext(),
((TextView) view).getText(), Toast.LENGTH_SHORT).show();
}
});
}
public void registerContentObservers() {
this.getApplicationContext()
.getContentResolver()
.registerContentObserver(
android.provider.CallLog.Calls.CONTENT_URI, true,
new RatedCallsContentObserver(handler));
}
public void unregisterContentObservers() {
this.getApplicationContext()
.getContentResolver()
.unregisterContentObserver(
new RatedCallsContentObserver(handler));
}
}
I think the problem is that you need to close the db when your activity is destroyed. Try adding this to your activity:
@Override
protected void onDestroy() {
super.onDestroy();
if (openHelper != null) {
openHelper.close();
}
if (cdh != null) {
cdh.close();
}
}
and add this to your CallDataHelper class:
public void close() {
// NOTE: openHelper must now be a member of CallDataHelper;
// you currently have it as a local in your constructor
if (openHelper != null) {
openHelper.close();
}
}
EDIT 2: Also change the CallDataHelper constructor to:
// Declare openHelper as a member variable
OpenHelper openHelper = null;
public CallDataHelper(Context context) {
this.context = context;
openHelper = new OpenHelper(this.context);
this.db = openHelper.getWritableDatabase();
}
This should successfully close the database connection that was created by both of your OpenHelper
instances.
( EDITED to reflect the fact that you use two OpenHelper instances.)
这篇关于Android的错误 - 关闭()从来没有明确要求数据库的文章就介绍到这了,希望我们推荐的答案对大家有所帮助,也希望大家多多支持IT屋!