在GitHub上,审稿人和受让人有什么区别? [英] On GitHub, what's the difference between reviewer and assignee?

查看:3964
本文介绍了在GitHub上,审稿人和受让人有什么区别?的处理方法,对大家解决问题具有一定的参考价值,需要的朋友们下面随着小编来一起学习吧!

问题描述

2016年12月7日增加的一项功能,在GitHub博客上发布,引入了选项


您可以现在请求协作者明确查看,以便更轻松地指定要查看您的拉取请求的人员。



您还可以查看您是谁的人员列表正在等待审核,以及已经离开这些人的评论状态。


然而,显式设置PR的审阅者已经通过分配人员( assignees 选项)完成。



现在可以使用这两个选项,每个选项,因为他们都有共同的最终目标?


在与几位OSS维护人员讨论后, 被定义为该词应该是什么意思:复审(某人的代码)和受让人有一个更宽松的定义。

对于审阅者:您想查看代码的人。不一定是负责该区域或负责合并提交的人员。就像GitHub自动建议的那样,可以成为那些代码的工作人员。



对于受让人:直到项目团队/维护者意味着什么,没有严格的定义。它可以是公关公开组织,也可以是该领域的负责人(在审查完成或接近完成后将接受公关)。不需要GitHub来定义它为项目维护人员提供的最适合他们项目的东西。



以前的回答:



好吧,我会继续回答我自己的问题。



访问:受让人将是开放公关的同一人,并且审核人将替换旧受理人功能(审核代码),这是受让人选择的人。



对于没有写入权限的用户(外部贡献者)的PR:具有写入权限的用户可以指定自己(或其他写入权限成员)查看PR(审阅者)。受让人是空白的。



来自外部撰稿人的未完成的公关:写入访问成员将完成未完成的工作并为她指定。她将负责完成任务,即受让人。由于PR的主要原因是审查更改,她会选择其他人来检查更改。


A feature added on Dec, 7, 2016, announced on GitHub blog, introduced the option to add reviewers to a Pull Request

You can now request a review explicitly from collaborators, making it easier to specify who you'd like to review your pull request.

You can also see a list of people who you are awaiting review from in the pull request page sidebar, as well as the status of reviews from those who have already left them.

However, explicit setting a reviewer for a PR was already done by assigning people (assignees option).

With both options now available, what's the role of each option since they both share the same end goal?

解决方案

EDIT:

After discussing with several OSS maintainers, reviewers is defined as what the word supposed to be: to review (someone's code) and "assignee" has a looser definiton explained below.

For "reviewer": someone you want to review the code. Not necessarily the person responsible for that area or responsible for merging the commit. Can be someone who worked on that chunk of code before, as GitHub auto-suggests.

For "assignee": up to the project's team/maintainer what it means and there's no strict definition. It can be the PR opener, or someone responsible for that area (who is going to accept the PR after the review is done or just close it). It's not up to GitHub to define what it is leaving it open for project maintainers what fits best for their project.

Previous answer:

Ok I'll go ahead and answer my own question.

For PR of users with write-access: the Assignee would be the same person who opened the PR, and reviewer would replace the old assignee function (reviewing code), being this one someone of assignee choice.

For PR of users without write-access (outside contributors): Someone with write-access would assign herself (or other write-priviledge member), to review the PR (Reviewer). Assignee is blank.

For unfinished PR from outside contributors: the write-access member would take the unfinished work and assign for her. She will be responsible for finishing the task, being the Assignee. Since the main reason of PRs is reviewing changes, she would select some other people to review the changes.

这篇关于在GitHub上,审稿人和受让人有什么区别?的文章就介绍到这了,希望我们推荐的答案对大家有所帮助,也希望大家多多支持IT屋!

查看全文
登录 关闭
扫码关注1秒登录
发送“验证码”获取 | 15天全站免登陆