TFS代码审查 - 显示更新的文件在回应评论 [英] TFS Code Reviews - Show updated files in response to comments

问题描述

我们都开始使用内置在VS 2012和VS 2013的预览代码审查功能。请求的审查和添加注释似乎非常简单。 ？如果有人添加注释请求的代码被改变，那么如何请求方做出这些变化，并告诉他们。

We are beginning to use the code review functionality built-in to VS 2012 and VS 2013 preview. Requesting the review and adding comments seem pretty straightforward. If someone adds comments requesting the code to be changed, then how does the requester make these changes and show them?

所以这个过程会流是这样的：

So the process would flow like this:

1. 人员1请求代码审查。


2. 人员2增加了意见，并选择工作需要。


3. 1个人进行必要的更改。

如何人1现在证明这些变化给2个人？您可以添加注释，并将它们发送，但文件不会改变。我假设这些文件是从被要求原来的审查时创建的变更。人应该接近1这一审查，并要求第二次审查？

How does Person 1 now show these changes to Person 2? You can add comments and send them, but the files don't change. I'm assuming the files are from the changeset created when the original review was requested. Should Person 1 close this review, and request a second review?

创建第二次审查似乎不是最佳的，因为你失去了你，为什么你的谈话的历史进行更改。

Creating a second review doesn't seem optimal, because you lose the history of your conversation of why you were making the changes.

有吨的网站展示了如何使用的代码审查的基本功能，但有没有表现出最好的做法任何网站？ ？例如，谁应该被点击旁边的复选框文件

There are ton of websites showing how to use the basic functionality of the code reviews, but are there any sites that show the best practices? For instance, who should be clicking the check boxes next to files?

推荐答案

所以这个过程会流是这样的：

So the process would flow like this:

1. 1人请求代码审查。


2. 2人增加了意见，并选择工作需要。


3. 1人进行必要的修改。


4. 人员1更新的代码审查相关搁置


5. 人员1加评论继续讨论

1. Person 1 requests a code review.
2. Person 2 adds comments and selects "Needs Work."
3. Person 1 makes the necessary changes.
4. Person 1 Updates the shelveset associated with the code review
5. Person 1 adds comments to continue the discussion
6. Repeat steps 2 - 5 until accepted

下面是更新审查相关搁置的必要步骤5 - >重复步骤2。

Here are the steps necessary to update the shelveset associated with the review.

1. 从代码评审窗格中选择查看搁置链接


2. 从搁置详细信息窗格中突出显示并复制搁置名称


3. 导航到挂起的更改窗格中，单击搁置，并粘贴搁置名称


4. 按搁置更换验证对话框


5. 现在，审稿人可以看到更新的文件和审查的讨论能继续Yes按钮

1. From the "Code Review" pane select the "view shelveset" link
2. From the "Shelveset Details" pane highlight and copy the shelveset name
3. Navigate to the "Pending Changes" pane, click on "Shelve" and paste the shelveset name
4. Press the Yes button on the shelveset replace verification dialog
5. Now the reviewer can see the updated files and the review discussion can continue

我已经包括了一些屏幕截图，因为我觉得它有助于澄清的事情。

I've included some screen shots as I find it helps to clarify things.

1）从代码评审窗格中选择查看搁置的链接如下所示：

1) From the "Code Review" pane select the "view shelveset" link as shown here:

2）从搁置详细信息窗格中突出显示并复制搁置名称如下所示：

2) From the "Shelveset Details" pane highlight and copy the shelveset name as shown here:

3）导航到挂起的更改窗格中，单击搁置和粘贴例如搁置名称：

3) Navigate to the "Pending Changes" pane, click on "Shelve" and paste the shelveset name for example:

4）按搁置更换验证对话框中的是按钮：

4) Press the Yes button on the shelveset replace verification dialog:

这篇关于TFS代码审查 - 显示更新的文件在回应评论的文章就介绍到这了，希望我们推荐的答案对大家有所帮助，也希望大家多多支持IT屋！