MVC3使用路由还是使用控制器逻辑？ [英] MVC3 using routes or using controller logic?
问题描述
我是相对较新的MVC3，但我使用它，C＃和EF4创建一个应用程序网站。我使用的路由与默认的Microsoft项目创建时，我选择MVC3模式相同，没有什么特别的：
public static void RegisterRoutes（RouteCollection routes）
{
routes.IgnoreRoute（{resource} .axd / {* pathInfo}）;
routes.MapRoute（
Default，//路由名称
{controller} / {action} / {id}，//带参数的URL
new {controller =Home，action =Index，id = UrlParameter.Optional}，//参数默认值
new [] {MySite.Controllers}
）;
}
我们使用默认的成员资格提供程序，用户也获得一个INT值来标识他们的帐户。这样，他们就可以很容易地通过简单的路由查看其个人资料：
www.mysite.com/profile/4
...例如。但是，客户端已要求预先生成许多帐户并将其分发给选定的用户。我已经设法通过SQL Server运行它的工作正常，所有的帐户都创建了（大约一千）。此外，我添加了一个位字段（Claimed），可以帮助确定这些用户是否已激活其中一个预先生成的帐户。
我的问题是，当用户获得访问他们（未激活）帐户的链接时，我应该在该网页上执行初始路由时使用测试来将其帐户标识为未声明并将它们发送到其他地方以完成在他们的帐户中输入详细信息？或者，我应该让他们与其他人一样访问同一页面，并在控制器逻辑中有一些标识该记录为未声明的内容，然后将其发送到另一个页面以完成输入详细信息等。 ？
那些在他们的Id值中组成（或有排字错误）的人，比如：
www.mysite.com/profile/40000000000
（到目前为止，网站只有千位用户）应该类似地处理，还是通过不同的手段完全处理？ （也就是说，在一种情况下，我们要确定一个尚未声明的现有帐户，在另一种情况下，我们必须确定该帐户甚至不存在。）
任何帮助将非常感激。
编辑：
我试图实现Soliah的建议的解决方案，并卡住了一个事实，即if（id！= 0）不喜欢的id可能不是一个INT。我现在已经过去，试图找出一种方法来检查如果有效部分，但可能我没有解决的问题与id不被视为一个INT？事情是绝对不正确的，即使我试图在我的数据库测试期间再次转换它的有效性。任何想法为什么我得到错误下面？我缺少什么？
public class ValidProfileIdAttribute：ActionFilterAttribute
{
public override void OnActionExecuting（ActionExecutingContext filterContext ）
{
var id =（Convert.ToInt32（filterContext.ActionParameters [Id]）））;
if（id！= 0）
{
//检查是否有效，并在此处相应地进行操作。
Profile profile = db.Profiles.Where（q => q.ProfileId ==（Convert.ToInt32（id）））。FirstOrDefault（）;
}
base.OnActionExecuting（filterContext）;
}
}
无法将类型System.Linq.IQueryable< Mysite.Models.Profile>'隐式转换为'Mysite.Models.Profile'。显示转换存在（是否缺少转换？）
编辑＃ strong>
我正在处理Robert的建议，并取得部分进展。我的代码目前看起来像这样：
public class UserAccountActivatedAttribute：ActionMethodSelectorAttribute
{
public override bool IsValidForRequest ControllerContext controllerContext，System.Reflection.MethodInfo methodInfo）
{
if（controllerContext == null）
{
throw new ArgumentNullException（controllerContext）;
}
bool isActivated = //获取这个状态的代码
return isActivated;
}
}
（相信或不相信）这则讯息： http://pastebin.com/Ea09Gf4B
我需要将ActionSelectorAttribute更改为ActionMethodSelectorAttribute，以便让事情再次移动。
但是，我看不到怎么做以获取Id值进入bool isActivated测试。我的数据库有一个视图（'Claimed'），它可以返回一个真/假值，这取决于用户的配置文件Id，它被交付，但我不知道在哪里添加Id。
if（int.TryParse（filterContext.ActionParameters [Id]，id）& ;& id！= 0）{
bool isActivated = db.Claimed.Where（c => c.ProfileId == id）.FirstOrDefault
编辑＃3：
这是我当前的代码状态：
public class UserAccountActivatedAttribute：ActionMethodSelectorAttribute
{
public override bool IsValidForRequest（ControllerContext controllerContext，System.Reflection.MethodInfo methodInfo）
{
if（controllerContext == null）
{
throw newArgumentNullException（controllerContext） ;
}
//首先获取配置文件id
int id = int.Parse（（string）controllerContext.RouteData.Values [id]）;
var profile = db.Profiles.Where（q => q.ProfileId == id）.FirstOrDefault（）;
bool isActivated = profile; //一些代码获得这个状态
return isActivated;
}
}
对我来说， parse（（string）controllerContext.RouteData.Values让他们工作，他们似乎做了（到那一点。）我发现格式化在这里：将routevalue绑定到作为viewmodel一部分的对象的属性
行
var profile = db.Profiles.Where（q => ; q.ProfileId == id）.FirstOrDefault（）;
错误消息如下：
无法通过嵌套类型MySite访问外部类型MySite.Controllers.HomeController的非静态成员。 Controllers.HomeController.UserAccountActivatedAttribute'
...这是我勤奋地试图找出与MSDN和Stack，只有上来空。
其他人已经提出了很多事情，但是让我把一些东西带到这里。 / p>
操作方法选择器
为了保持控制器操作干净，可以将action方法selector属性创建两个简单的操作：
[ActionName（Index）]
public ActionResult IndexNonActivated（int id）
{
...
}
[ActionName（Index）]
[UserAccountActivated]
public ActionResult IndexActivated（int id）
{
...
}
t处理在你的行动中检查代码，保持它们很薄。
您可以在中阅读更多有关操作选择器属性的信息。选择器过滤器将确保正确的操作与用户帐户激活状态相关。 /erraticdev.blogspot.com/2010/12/using-custom-action-method-selector.htmlrel =nofollow>我的博客帖子，但基本上你必须写类似于这样的东西： / p>
public class UserAccountActivatedAttribute：ActionMethodSelectorAttribute
{
public override bool IsValidForRequest（ControllerContext controllerContext，MethodInfo methodInfo）
{
if（controllerContext == null）
{
throw new ArgumentNullException（controllerContext）;
}
//首先获取配置文件ID
int id = int.Parse（controllerContext.RouteData.Values [id] ?? -1）;
bool isActivated = //获取这个状态的代码
return isActivated;
}
}
基本上就是这样。
无论用户的帐户是否被激活，用户都可以访问他们的个人资料。
一个重要的优点
如果您有两个不同名称的动作（如Juraj所建议的），一个用于活动配置文件和其他用于激活的动作，则您必须同时进行检查，因为即使活动用户也能访问激活操作：
个人资料/ 4>对于活动配置文件
profile / activate / 4>对于非活动配置文件
两个操作都应该检查状态， 适合。这也意味着每次发生重定向时，配置文件将被检查两次。
操作方法选择器只会检查个人资料一次。无论用户个人资料处于什么状态。
I'm relatively new with MVC3, but I'm using it, C# and EF4 to create an application website. The routing that I'm using is the same as in the default Microsoft project created when I selected MVC3 pattern, nothing special:
public static void RegisterRoutes(RouteCollection routes)
{
routes.IgnoreRoute("{resource}.axd/{*pathInfo}");
routes.MapRoute(
"Default", // Route name
"{controller}/{action}/{id}", // URL with parameters
new { controller = "Home", action = "Index", id = UrlParameter.Optional }, // Parameter defaults
new[] { "MySite.Controllers" }
);
}
And everything is working fine there. We're using the default Membership Provider, and users also get an INT value that identifies their account. This lets them see their profile pretty easily with a simple routing like:
www.mysite.com/profile/4
...for example. However, the client has asked that a lot of accounts be pre-generated and distributed to selected users. I've worked up a way to run that through SQL Server and it works fine, all the accounts got created (about a thousand). Additionally, I've add a bit field ('Claimed') that can help identify whether one of these pre-generated accounts has been 'activated' by these users.
My question is, when a user is given a link to come visit their (un-activated) account, should I use a test when doing the initial routing on that page to identify their account as un-claimed and send them somewhere else to finish entering details into their account? Or should I let them go to the same page as everyone else, and have something in the controller logic that identifies this record as un-claimed, and then send them to another page to finish entering details etc.? Is there a good reason for doing one over the other?
And what about people who make up (or have a typographical error) in their Id value, like:
www.mysite.com/profile/40000000000
(and the site only has a thousand users so far), should that be handled similarly, or through different means entirely? (I.e., in one scenario we're identifying an existing account that is not yet claimed, and in another scenario we're having to figure out that the account doesn't even exist.)
Any help would be greatly appreciated.
EDIT:
I'm trying to implement Soliah's suggested solution, and got stuck a bit on the fact that the if (id != 0) didn't like that the id might not be in an INT. I'm past that now, and attempting to figure out a way to do the check if valid portion, but possibly I have not solved the problem with the id not being treated as an INT? Something is definitely not right, even though I'm trying to convert it again during my database test for validity. Any ideas on why I'm getting the error below? What am I missing?
public class ValidProfileIdAttribute : ActionFilterAttribute
{
public override void OnActionExecuting(ActionExecutingContext filterContext)
{
var id = (Convert.ToInt32(filterContext.ActionParameters["Id"]));
if (id != 0)
{
// Check if valid and behave accordingly here.
Profile profile = db.Profiles.Where(q => q.ProfileId == (Convert.ToInt32(id))).FirstOrDefault();
}
base.OnActionExecuting(filterContext);
}
}
Cannot implicitly convert type 'System.Linq.IQueryable<Mysite.Models.Profile>' to 'Mysite.Models.Profile'. An explicit conversion exists (are you missing a cast?)
EDIT #2:
I'm working on Robert's suggestion, and have made partial progress. My code currently looks like this:
public class UserAccountActivatedAttribute : ActionMethodSelectorAttribute
{
public override bool IsValidForRequest(ControllerContext controllerContext, System.Reflection.MethodInfo methodInfo)
{
if (controllerContext == null)
{
throw new ArgumentNullException("controllerContext");
}
bool isActivated = // some code to get this state
return isActivated;
}
}
which I got to after reading the blog entry, and (believe it or not) this posting: http://pastebin.com/Ea09Gf4B
I needed to change ActionSelectorAttribute to ActionMethodSelectorAttribute in order to get things moving again.
However, what I don't see how to do is to get the Id value into the bool isActivated test. My database has a view ('Claimed') which can give back a true/false value, depending on the user's profile Id that it is handed, but I don't see where to add the Id. Would something like what Soliah edited work?
if (int.TryParse(filterContext.ActionParameters["Id"], id) && id != 0) {
bool isActivated = db.Claimed.Where(c => c.ProfileId == id).FirstOrDefault();
EDIT #3:
Here is my current state of the code:
public class UserAccountActivatedAttribute : ActionMethodSelectorAttribute
{
public override bool IsValidForRequest(ControllerContext controllerContext, System.Reflection.MethodInfo methodInfo)
{
if (controllerContext == null)
{
throw new ArgumentNullException("controllerContext");
}
// get profile id first
int id = int.Parse((string)controllerContext.RouteData.Values["id"]);
var profile = db.Profiles.Where(q => q.ProfileId == id).FirstOrDefault();
bool isActivated = profile;// some code to get this state
return isActivated;
}
}
For me, I had to change things to int.Parse((string)controllerContext.RouteData.Values to get them to work, which they seem to do (to that point.) I discovered that formatting here: Bind a routevalue to a property of an object that is part of viewmodel
The line
var profile = db.Profiles.Where(q => q.ProfileId == id).FirstOrDefault();
errors on the db. section, with error message as follows:
Cannot access a non-static member of outer type 'MySite.Controllers.HomeController' via nested type 'MySite.Controllers.HomeController.UserAccountActivatedAttribute'
...which is something that I have diligently tried to figure out with MSDN and Stack, only to come up empty. Does this ring any bells?
Others have suggested many things already, but let me bring something else to the table here.
Action Method Selector
In order to keep your controller actions clean, you can write an action method selector attribute to create two simple actions:
[ActionName("Index")]
public ActionResult IndexNonActivated(int id)
{
...
}
[ActionName("Index")]
[UserAccountActivated]
public ActionResult IndexActivated(int id)
{
...
}
This way you don't deal with checking code in your actions keeping them really thin. Selector filter will make sure that correct action will get executed related to user account activation state.
You can read more about action selector attributes in my blog post but basically you'd have to write something similar to this:
public class UserAccountActivatedAttribute : ActionMethodSelectorAttribute
{
public override bool IsValidForRequest(ControllerContext controllerContext, MethodInfo methodInfo)
{
if (controllerContext == null)
{
throw new ArgumentNullException("controllerContext");
}
// get profile id first
int id = int.Parse(controllerContext.RouteData.Values["id"] ?? -1);
bool isActivated = // some code to get this state
return isActivated;
}
}
And that's basically it.
This will make it possible for users to access their profile regardless whether their account has been activated or not. Or maybe even deactivated at some later time... And it will work seamlessly in the background.
One important advantage
If you'd have two actions with different names (as Juraj suggests), one for active profiles and other for activation, you'd have to do the checking in both, because even active users would be able to access activation action:
profile/4 > for active profiles
profile/activate/4 > for inactive profiles
Both actions should be checking state and redirect to each other in case that state doesn't "fit". This also means that each time a redirection would occur, profile will get checked twice. In each action.
Action method selector will check profiles only once. No matter what state user profile is in.
这篇关于MVC3使用路由还是使用控制器逻辑？的文章就介绍到这了，希望我们推荐的答案对大家有所帮助，也希望大家多多支持IT屋！
