编辑方法正在创建新记录,而不是仅更新现有记录 [英] Edit method is creating new records, instead of just updating existing ones

查看:301
本文介绍了编辑方法正在创建新记录,而不是仅更新现有记录的处理方法,对大家解决问题具有一定的参考价值,需要的朋友们下面随着小编来一起学习吧!

问题描述

我的问题是:当我编辑个人资料页面时,如何使个人资料控制器的编辑/更新方法停止创建新记录?



我有一个用户模型和个人资料模型。

用户has_one:个人资料 br>
个人资料belongs_to:user



我的routes.rb如下所示:map.resources :users,:has_one =>:profile



当我的应用程式的访客建立一个使用者并点击提交时,系统会将他们导向至「建立个人资料」画面。 p>

以下控制器创建一个配置文件,以便创建的配置文件网址为:localhost:3000 / users / [user_id] / profile

  def new 
@profile =`current_user.build_profile`
end

def create
@profile = current_user .build_profile(params [:profile])
如果@ profile.save
flash [:notice] ='配置文件已成功创建'。
redirect_to user_profile_path
else
flash [:notice] ='错误。发生错误。
rendernew
end
end

这一切都很好。



编辑个人资料时出现问题。



初看起来似乎很好。当我转到编辑个人资料视图时,网址是正确的。例如,如果显示个人资料视图的网址为localhost:3000 / users / 1 / profile,则编辑个人资料视图显示为:localhost:3000 / users / 1 / profile / edit



这很好。



当我做一个更改并点击更新按钮,这似乎也工作。我得到指向正确的显示配置文件视图,我得到一个闪光通知确认更改。



这是奇怪的部分。当我回到我的个人资料索引以查看应用程序中的所有个人资料时,结果证明该应用程序每次更新个人资料时都创建了一个新的个人资料记录。原始配置文件记录仍然存在,但有新的其他记录。请注意,我应用程式中的所有个人资料都与使用者相关,使用者只能有一个个人资料。因此,如果我的应用程序中有5个用户,现在可能有10个不同的配置文件,每个配置文件都有一个url,导致一个被破坏的页面,因为user_id不存在于数据库中。例如,localhost:3000 / users / 7 / profile,users / 8 / profile等。



记录被保存到我的数据库中的配置文件表中, user_id列显示了一个NUL。



我认为问题来自(a)配置文件控制器中的编辑/更新方法,或者(b)



以下是我的个人资料控制器的编辑和更新方法:

  def edit 
@profile = current_user.profile(params [:id])
end

def update
@profile = current_user.profile.find(params [:id])
如果@ profile.update_attributes(params [:profile])
flash [:notice] =' $ b redirect_to(@profile)
else
renderedit
end


$ b b

end



这是档案的index.html.erb检视档案:

 code>< div id =posts> 
<%@ profiles.each do | profile | - %>
<%unless profile.blank? - %>
< div class =profiles>
< div class =right>
< p><%= h profile.name%>< / p>
< p><%= h profile.category%>< / p>
< / div>
< div class =bottom>
< p><%= link_to'请参阅个人资料',user_profile_path(个人资料)%>< / p&
< / div>
<%end - %>
< / div>
<%end - %>



重复我的问题:当我编辑个人资料页面时,我是否要为我的个人资料控制器的编辑/更新方法停止创建新记录?



UPDATE



查看日志,看起来它正在调用Edit方法,但是然后调用create方法而不是update方法来执行操作。这是我得到的:

 处理ProfilesController#编辑(为IP 2009-08-29 00:46:06) [GET] 
参数:{action=>edit,controller=>profiles,user_id=>1}
用户负载SELECT * FROMusersWHERE(users。id= 1)
配置文件加载(0.6ms)SELECT * FROMprofilesWHERE(profiles.user_id = 1)LIMIT 1
在布局/应用程序中渲染模板
渲染配置文件/编辑
SQL(0.3ms)SELECT count(*)AS count_all FROMpostsWHERE(posts.profile_id = 20)
呈现的用户/ _login(1.2ms)
完成在29ms(查看:16,DB:1)| 200 OK

[ http:// localhost / users / 1 / profile / edit]

 处理ProfilesController#create(for IP at 2009-08-29 00:46:21)[POST] 
参数:{commit=>Update,profile=> { =布鲁克林,address1=>贝德福德大道,名称=>地方,zip=>19876,地址2=& ,category=>餐厅,网站=>http://www.whatever.com,description=>地点是真棒。,手机=>555 -1212,email=>place@whatever.com,state=>NY},action=>create,authenticity_token=> ,controller=>profiles,user_id=>1}
用户加载(0.3ms)SELECT * FROMusersWHERE(users。id= 1)
Profile Load(0.6ms)SELECT * FROMprofilesWHERE(profiles.user_id = 1)LIMIT 1
配置文件更新(0.6ms)UPDATEprofilesSETupdated_at='2009-08 -29 04:46:21',user_id= NULL WHEREid= 20
配置文件创建(0.6ms)INSERT INTOprofiles(name,address1,city,address2 ,zip,category,updated_at,website,description,category_id,phone,user_id,state,email,created_at)VALUES ','贝德福德大道','布鲁克林','Apt。 4','19876','Restaurant','2009-08-29 04:46:21','http://www.whatever.com','Place is awesome。',NULL,'555-1212' ,1,'NY','place@whatever.com','2009-08-29 04:46:21')
重定向到http:// localhost:3000 / users / 1 / profile
完成在45ms(DB:2)| 302 Found [http:// localhost / users / 1 / profile]



UPDATE



我认为这是相关的部分,但让我知道如果你需要更多。

 <%@ profile.posts.build if @ profile.posts.empty? %> 
<%form_for:profile,@profile,:url => {:controller => 'profiles',:action => 'update'} do | profile_form | %>
<%= profile_form.error_messages%>


解决方案

您需要将嵌套属性的ID传递给使更新操作很好。
如果你没有传递嵌套对象的(允许的)id,rails将创建一个新的记录。


My question is: How do I make the edit/update methods for my profiles controller stop creating new records when I edit a profile page?

I have a user model and profile model.
user has_one :profile.
profile belongs_to :user.

My routes.rb looks like this: map.resources :users, :has_one => :profile

When a visitor to my app creates a user and hits submit, they are directed to the "create profile" screen.

The following controller, creates a profile such that the created profile url is: localhost:3000/users/[user_id]/profile

def new  
    @profile = `current_user.build_profile`  
end

def create
  @profile = current_user.build_profile(params[:profile])
  if @profile.save
    flash[:notice] = 'Profile was successfully created.'
    redirect_to user_profile_path
  else
    flash[:notice] = 'Error.  Something went wrong.'
    render "new"
  end
end

This all works fine.

The problem occurs when I edit a profile.

At first things seems fine. When I go to the "edit profile" view, the url is correct. For example, if the url for the "show profile" view is localhost:3000/users/1/profile, then the "edit profile" view appears as: localhost:3000/users/1/profile/edit

That's good.

When I make a change and click the update button, that seems to work as well. I get directed to the correct "show profile" view and I get a flash notice confirming the change.

So here's the weird part. When I go back to my index of profiles to view all the profiles in the app, it turns out that the app has created a new profile record each time I update the profile. The original profile record is still there, but there are new additional records. Keep in mind that all the profiles in my app are tied to a user, and the user can have only one profile. So if there are 5 users in my app, now there might be 10 different profiles, each with a url that leads to a busted page because the user_id doesn't exist in the database. For example, localhost:3000/users/7/profile, users/8/profile, etc.

The record gets saved to the profile table in my database, but the user_id column shows a NUL.

I figure that the problem is coming from either (a) the edit/update methods in the profiles controller, or (b) the code I'm using to display profiles on my profile index page.

Here's my profile controller for the edit and update methods:

def edit
    @profile = current_user.profile(params[:id])
end

def update
  @profile = current_user.profile.find(params[:id])
  if @profile.update_attributes(params[:profile])
    flash[:notice] = 'Profile was successfully updated.'
    redirect_to(@profile)
  else
    render "edit"
  end

end

Here's the profile index.html.erb view file:

<div id="posts">
  <% @profiles.each do |profile| -%>
    <% unless profile.blank? -%>
    <div class="profiles">
    <div class="right">
            <p><%=h profile.name %></p>
        <p><%=h profile.category %></p>
            </div>
    <div class="bottom">
            <p><%= link_to 'See Profile', user_profile_path(profile) %></p>
            </div>
    <% end -%>
</div>
<% end -%>

To repeat my question: How do I make the edit/update methods for my profiles controller stop creating new records when I edit a profile page?

UPDATE

Looking at the log, it looks like it's calling the Edit method, but then calling the "create" method instead of the "update" method to execute the action. Here's what I'm getting:

Processing ProfilesController#edit (for IP at 2009-08-29 00:46:06) [GET]  
  Parameters: {"action"=>"edit", "controller"=>"profiles", "user_id"=>"1"}  
  User Load (0.3ms)   SELECT * FROM "users" WHERE ("users"."id" = 1)   
  Profile Load (0.6ms)   SELECT * FROM "profiles" WHERE ("profiles".user_id = 1) LIMIT 1  
Rendering template within layouts/application  
Rendering profiles/edit  
  SQL (0.3ms)   SELECT count(*) AS count_all FROM "posts" WHERE ("posts".profile_id = 20)   
Rendered users/_login (1.2ms)  
Completed in 29ms (View: 16, DB: 1) | 200 OK 

[http://localhost/users/1/profile/edit]

Processing ProfilesController#create (for IP at 2009-08-29 00:46:21) [POST]  
  Parameters: {"commit"=>"Update", "profile"=>{"city"=>"Brooklyn", "address1"=>"Bedford Ave.", "name"=>"Place", "zip"=>"19876", "address2"=>"Apt. 4", "category"=>"Restaurant", "website"=>"http://www.whatever.com", "description"=>"Place is awesome.", "phone"=>"555-1212", "email"=>"place@whatever.com", "state"=>"NY"}, "action"=>"create", "authenticity_token"=>"[redacted]", "controller"=>"profiles", "user_id"=>"1"}  
  User Load (0.3ms)   SELECT * FROM "users" WHERE ("users"."id" = 1)   
  Profile Load (0.6ms)   SELECT * FROM "profiles" WHERE ("profiles".user_id = 1) LIMIT 1  
  Profile Update (0.6ms)   UPDATE "profiles" SET "updated_at" = '2009-08-29 04:46:21', "user_id" = NULL WHERE "id" = 20  
  Profile Create (0.6ms)   INSERT INTO "profiles" ("name", "address1", "city", "address2", "zip", "category", "updated_at", "website", "description", "category_id", "phone", "user_id", "state", "email", "created_at") VALUES('Place', 'Bedford Ave.', 'Brooklyn', 'Apt. 4', '19876', 'Restaurant', '2009-08-29 04:46:21', 'http://www.whatever.com', 'Place is awesome.', NULL, '555-1212', 1, 'NY', 'place@whatever.com', '2009-08-29 04:46:21')  
Redirected to http://localhost:3000/users/1/profile  
Completed in 45ms (DB: 2) | 302 Found [http://localhost/users/1/profile]  

UPDATE

I think this is the relevant part, but let me know if you need more. The rest is just the individual fields.

<% @profile.posts.build if @profile.posts.empty? %>  
<% form_for :profile, @profile, :url => { :controller => 'profiles', :action => 'update' } do |profile_form| %>  
<%= profile_form.error_messages %>

解决方案

You need to pass an ID of the nested attribute to make update action work well. If you didn't pass(permitted) id of nested object, rails will create a new record.

这篇关于编辑方法正在创建新记录,而不是仅更新现有记录的文章就介绍到这了,希望我们推荐的答案对大家有所帮助,也希望大家多多支持IT屋!

查看全文
相关文章
登录 关闭
扫码关注1秒登录
发送“验证码”获取 | 15天全站免登陆